Re: [PATCHES] libpq events patch (with sgml docs)

From: Andrew Chernow <ac(at)esilo(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Merlin Moncure <mmoncure(at)gmail(dot)com>
Subject: Re: [PATCHES] libpq events patch (with sgml docs)
Date: 2008-09-17 10:50:16
Message-ID: 48D0E0E8.5070301@esilo.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Chernow wrote:
> > Now, it's questionable how tense we need to be about that as long as
> > event proc failure aborts calling of later event procs. That means
> > that procs have to be robust against getting DESTROY with no CREATE
> > calls in any case. Should we try to make that less uncertain?
> >
> >
>
> I attached a patch that adds a 'needDestroy' member to PGEvent It is
> set when resultcreate or resultcopy succeeds and checked during a
> PQclear. That *should* resolve the issue of "no resultcreate but gets a
> resultdestroy".
>
>

Shoot. I have a booboo in that last patch. Attached is the corrected version.

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

Attachment Content-Type Size
pgevent.patch text/x-patch 3.5 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2008-09-17 12:12:09 Re: Common Table Expressions (WITH RECURSIVE) patch
Previous Message Andrew Chernow 2008-09-17 10:45:18 Re: [PATCHES] libpq events patch (with sgml docs)

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-09-17 12:16:52 Re: [PATCHES] libpq events patch (with sgml docs)
Previous Message Andrew Chernow 2008-09-17 10:45:18 Re: [PATCHES] libpq events patch (with sgml docs)