| From: | Heikki Linnakangas <heikki(dot)linnakangas(at)enterprisedb(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | David Rowley <dgrowley(at)gmail(dot)com>, 'Peter Eisentraut' <peter_e(at)gmx(dot)net>, pgsql-patches(at)postgresql(dot)org |
| Subject: | Re: [HACKERS] TODO item: Implement Boyer-Moore searching (First time hacker) |
| Date: | 2008-09-05 17:25:56 |
| Message-ID: | 48C16BA4.2060407@enterprisedb.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Tom Lane wrote:
> "David Rowley" <dgrowley(at)gmail(dot)com> writes:
>> Tom Lane wrote:
>>> Hmm. B-M-H has worst case search speed O(M*N) (where M = length of
>>> pattern, N = length of search string); whereas full B-M is O(N). Maybe we
>>> should build the second table when M is large?
>
>> I'll look into this. If it pays off for longer searches I'll submit a patch.
>> I won't have the time until after the 15th, so perhaps that's in November's
>> commit fest?
>
> Yes. Let's get B-M-H in during this fest and then you can look into
> whether a follow-on patch is worthwhile.
Agreed.
Also, it would be nice to use B-M(-H) for LIKE as well. That's a
different codepath, but probably more widely used than textpos and
frients. I haven't looked how feasible it would be to do, though.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-09-05 17:29:29 | Re: [HACKERS] TODO item: Implement Boyer-Moore searching (First time hacker) |
| Previous Message | Tom Lane | 2008-09-05 17:25:34 | Re: 8.4devel out of memory |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-09-05 17:29:29 | Re: [HACKERS] TODO item: Implement Boyer-Moore searching (First time hacker) |
| Previous Message | Tom Lane | 2008-09-05 17:12:17 | Re: [HACKERS] TODO item: Implement Boyer-Moore searching (First time hacker) |