Re: libpq events patch

From: Andrew Chernow <ac(at)esilo(dot)com>
To: "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org>
Subject: Re: libpq events patch
Date: 2008-09-03 22:10:53
Message-ID: 48BF0B6D.6020006@esilo.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Andrew Chernow wrote:
> This is an updated version pf the libpqevents patch. See
>
> http://archives.postgresql.org/pgsql-hackers/2008-09/msg00153.php
>
> for details. The only change I didn't make yet is the event 'name'. I
> have put it in and taken it out twice now, so a firm 'put it in there'
> would be appreciated.
>
> Go here for libpqtypes using events. pgfoundry is still using the older
> object hooks version.
>
> http://libpqtypes.esilo.com/libpqtypes-events.tar.gz
>
>

Patch update again. This one includes an optional event name for
debugging purposes. It also includes the changes made by Alvaro that I
missed.

PQregisterEventProc now takes a name argumet. If the name is NULL, the
error message will identify the event procedure by its address ...
"addr:%p". If its not NULL, error messages will indicate the provided name.

I updated the styling in libpq-events.c and a couple places in fe-exec.c
that Alvaro missed.

--
Andrew Chernow
eSilo, LLC
every bit counts
http://www.esilo.com/

Attachment Content-Type Size
libpq-events.patch text/plain 28.2 KB
libpq-events.tgz application/x-compressed 8.8 KB

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Hannu Krosing 2008-09-03 22:26:44 Re: [PATCH] Cleanup of GUC units code
Previous Message Kevin Grittner 2008-09-03 21:27:29 Re: IN vs EXISTS equivalence

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-09-04 00:03:54 Re: Extending grant insert on tables to sequences
Previous Message Andrew Chernow 2008-09-03 17:14:03 Re: libpq object hooks (libpq events)