Re: [PATCH] Cleanup of GUC units code

Marko Kreen wrote:
> On 9/2/08, Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>> Marko Kreen wrote:
>>> In the meantime, here is simple patch for case-insensivity.
>> You might be able to talk me into accepting various unambiguous, common
>> alternative spellings of various units. But for instance allowing MB and Mb
>> to mean the same thing is insane.
>
> How would the docs for that look like? And anyway, what is wrong with
> Mb for megabytes?

I doesn't seem completely unreasonable to me that we'd want to express
something in megabits/second in the future. For example, instead of
vacuum_cost_delay, it would be cool to specify a bandwidth allowance.
Megabits/second is a completely reasonable unit for that. Or a limit on
network bandwidth.

FWIW, I don't feel very strongly either way. I'm more than happy with
the status quo. The hint in the error message very clearly spells out
what the valid values are, so it's immediately clear what you need to
fix if you get that wrong.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com