Re: [patch] GUC source file and line number

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Greg Smith <gsmith(at)gregsmith(dot)com>
Cc: Alvaro Herrera <alvherre(at)commandprompt(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [patch] GUC source file and line number
Date: 2008-08-28 22:00:29
Message-ID: 48B71FFD.3050407@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Greg Smith wrote:
> This looks quite handy. Needs to have an update to the view-pg-settings
> section of the docs before it gets applied though.
>
> I'd also like to get the default boot_val for each parameter exposed,
> similarly to how the min and max are available. That should be easy to
> do using your changes as a guide for what to touch. I'll try to fit
> that in this weekend so it makes the commitfest deadline. I'll update
> the docs for all the changes (the ones in there already and the one I
> add) while I'm at it and submit a combined patch.

Doing that is going to be a whole lot easier and less invasive, so I'd
suggest doing it as a separate patch. While there may be a small
conflict, it's going to be easy to resolve, and I think keeping them
apart makes it a lot easier to review - at least to review the simple patch.

//Magnus

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message PoolSnoopy 2008-08-29 01:19:09 Re: libpq does not manage SSL callbacks properly when other libraries are involved.
Previous Message Greg Smith 2008-08-28 21:20:48 Re: [patch] GUC source file and line number