Re: gsoc, oprrest function for text search take 2

From: Jan Urbański <j(dot)urbanski(at)students(dot)mimuw(dot)edu(dot)pl>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Simon Riggs <simon(at)2ndQuadrant(dot)com>, Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, Postgres - Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: gsoc, oprrest function for text search take 2
Date: 2008-08-27 07:14:17
Message-ID: 48B4FEC9.6000306@students.mimuw.edu.pl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> =?UTF-8?B?SmFuIFVyYmHFhHNraQ==?= <j(dot)urbanski(at)students(dot)mimuw(dot)edu(dot)pl> writes:
>> Simon Riggs wrote:
>>> put it in a file called selfuncs_ts.c so it is similar to the existing
>>> filename?
>
>> I followed the pattern of ts_parse.c, ts_utils.c and so on.
>> Also, I see geo_selfuncs.c. No big deal, though, I can move it.
>
> Given the precedent of geo_selfuncs.c, I think you were right the
> first time. A more interesting question is whether it should just
> get folded into selfuncs.c ...

selfuncs.c is a 5.8k lines beast, I felt a bit intimidated when first
opened it. The code in ts_selfuncs.c relies strongly on what the code in
ts_typanalyze.c does and that was another reason for putting in in its
own file next to ts_typanalyze.c. I don't really care to be honest,
might as well stick it into selfuncs.c.

--
Jan Urbanski
GPG key ID: E583D7D2

ouden estin

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Grant Finnemore 2008-08-27 07:35:03 Re: Proposal to sync SET ROLE and pg_stat_activity
Previous Message Alvaro Herrera 2008-08-27 02:44:48 Re: can't stop autovacuum by HUP'ing the server