Re: Support of INHERIT in existing tables (8.2+ releases)

Dave Page a écrit :
> On Mon, Jul 14, 2008 at 8:09 PM, Guillaume Lelarge
> <guillaume(at)lelarge(dot)info> wrote:
>> This patch fixes the issue you found.
>
> Seems to add another though :-(
>
> ..\..\src\common\string.cpp(2501): assert "nIndex < m_nCount" failed
> in wxArrayString::RemoveAt(): bad index in wxArrayString::Remove
>
> Call stack:
> [00] wxGUIAppTraitsBase::ShowAssertDialog
> c:\pgbuild\wxwidgets\src\common\appcmn.cpp:635
> [01] ShowAssertDialog
> c:\pgbuild\wxwidgets\src\common\appbase.cpp:836
> [02] wxAppConsole::OnAssertFailure
> c:\pgbuild\wxwidgets\src\common\appbase.cpp:445
> [03] wxOnAssert
> c:\pgbuild\wxwidgets\src\common\appbase.cpp:713
> [04] wxArrayString::RemoveAt
> c:\pgbuild\wxwidgets\src\common\string.cpp:2501
> [05] dlgTable::GetSql
> c:\pgbuild\buildtrees\pgadmin3\pgadmin\dlg\dlgtable.cpp:562
> [06] dlgTable::CheckChange
> c:\pgbuild\buildtrees\pgadmin3\pgadmin\dlg\dlgtable.cpp:974
> [07] dlgTable::OnAddTable
> c:\pgbuild\buildtrees\pgadmin3\pgadmin\dlg\dlgtable.cpp:1018
> [08] wxAppConsole::HandleEvent
> c:\pgbuild\wxwidgets\src\common\appbase.cpp:323
> [09] wxEvtHandler::ProcessEventIfMatches
> c:\pgbuild\wxwidgets\src\common\event.cpp:1232
> [10] wxEventHashTable::HandleEvent
> c:\pgbuild\wxwidgets\src\common\event.cpp:906
> [11] wxEvtHandler::ProcessEvent
> c:\pgbuild\wxwidgets\src\common\event.cpp:1292
> [12] wxWindowBase::TryParent
> c:\pgbuild\wxwidgets\src\common\wincmn.cpp:2661
> [13] wxEvtHandler::ProcessEvent
> c:\pgbuild\wxwidgets\src\common\event.cpp:1306
> [14] wxWindowBase::TryParent
> c:\pgbuild\wxwidgets\src\common\wincmn.cpp:2661
> [15] wxEvtHandler::ProcessEvent
> c:\pgbuild\wxwidgets\src\common\event.cpp:1306
> [16] wxWindowBase::TryParent
> c:\pgbuild\wxwidgets\src\common\wincmn.cpp:2661
> [17] wxEvtHandler::ProcessEvent
> c:\pgbuild\wxwidgets\src\common\event.cpp:1306
> [18] wxControl::ProcessCommand
> c:\pgbuild\wxwidgets\src\msw\control.cpp:321
> [19] wxButton::SendClickEvent
> c:\pgbuild\wxwidgets\src\msw\button.cpp:476
> [20] wxButton::MSWCommand
> c:\pgbuild\wxwidgets\src\msw\button.cpp:505
>

Sorry to answer so late, it was a lot of work to get everything working.
Anyways, fixed.

>> I have one question about inherited columns display in the table properties
>> dialog. There's a "Inherited from" column on the Columns tab. It shows the
>> word "inherited" when the column is inherited. But I initialy thought it
>> would show the table name of the inherited column. Is it a bug? (btw, I
>> checked in 1.8.4, it works the same (or it bugs the same :) ))
>
> Yes, I think you're correct - that does seem like a bug. Can you fix
> that while you're in there?
>

Fixed in the same patch. Don't know if you want a backpatch for 1.8?

Complete patch available at:
http://developer.pgadmin.org/~guillaume/inherit82+_20080810.patch.bz2

--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com