Re: Why we don't panic in PageGetExactFreeSpace

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Why we don't panic in PageGetExactFreeSpace
Date: 2008-08-05 18:29:59
Message-ID: 48989C27.6060100@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane napsal(a):
> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
>> It seems to me that we should panic that data are overlaped instead of return
>> zero.
>
> elog(PANIC) is almost never a good idea, and it certainly isn't a good
> response here.

Ok PANIC is too strong, but I guess FATAL should be relevant or is there any
situation when lower > upper? The same situation is in PageGetFreeSpace.

Zdenek

--
Zdenek Kotala Sun Microsystems
Prague, Czech Republic http://sun.com/postgresql

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Gregory Stark 2008-08-05 18:38:44 Re: DROP DATABASE always seeing database in use
Previous Message Tom Lane 2008-08-05 18:20:40 Re: Why we don't panic in PageGetExactFreeSpace