Re: unnecessary code in_bt_split

Tom Lane napsal(a):
> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:

> I'm thinking we should split PageGetTempPage into two versions:
>
> PageGetTempPage: get a temp page the same size as the given page,
> but don't initialize its contents at all (so, just a thin wrapper
> for palloc). This could be used by _bt_split, as well as
> GinPageGetCopyPage and GistPageGetCopyPage.
>
> PageGetTempPageCopySpecial: get a temp page, PageInit it, and
> copy the special space from the given page. The only customer
> for this is gistplacetopage(), so maybe we don't even want it,
> rather than just doing the work right in gistplacetopage()?
>
> You could also make an argument for PageGetTempPageCopy() which'd just
> copy the source page verbatim, thus replacing GinPageGetCopyPage and
> GistPageGetCopyPage.

Sounds good I will look on it.

Zdenek

--
Zdenek Kotala Sun Microsystems
Prague, Czech Republic http://sun.com/postgresql