| From: | Daniel Gustafsson <daniel(at)yesql(dot)se> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | "Jonathan S(dot) Katz" <jkatz(at)postgresql(dot)org>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Magnus Hagander <magnus(at)hagander(dot)net>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: Potentially misleading name of libpq pass phrase hook |
| Date: | 2020-05-16 07:16:54 |
| Message-ID: | 4885CB6A-ECA1-4752-A055-E32FBC62FC1C@yesql.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On 16 May 2020, at 03:56, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, May 15, 2020 at 09:21:52PM -0400, Jonathan S. Katz wrote:
>> +1 on all of the above.
>>
>> I noticed this has been added to Open Items; I added a note that the
>> plan is to fix before the Beta 1 wrap.
>
> +1. Thanks.
>
> Agreed. PQsslKeyPassHook_<library>_type sounds fine to me as
> convention. Wouldn't we want to also rename PQsetSSLKeyPassHook and
> PQgetSSLKeyPassHook, appending an "_OpenSSL" to both?
Yes, I think we should. The attached performs the rename of the hook functions
and the type, and also fixes an off-by-one-'=' in a header comment which my OCD
couldn't unsee.
cheers ./daniel
| Attachment | Content-Type | Size |
|---|---|---|
| openssl_hook_rename.patch | application/octet-stream | 6.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Christopher Baines | 2020-05-16 07:20:29 | Re: [PATCH] Fix pg_dump --no-tablespaces for the custom format |
| Previous Message | Tom Lane | 2020-05-16 04:33:52 | Re: pgindent && weirdness |