| From: | Markus Wanner <markus(at)bluegap(dot)ch> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Re: [COMMITTERS] pgsql: Adjust things so that the query_string of a cached plan and the |
| Date: | 2008-07-21 14:55:10 |
| Message-ID: | 4884A34E.4050002@bluegap.ch |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Hi,
Tom Lane wrote:
> This seems like a bad idea, because it makes the code gratuitously
> different from the names used for this purpose everywhere else.
I find that a pretty dubious reason for having 'query_string' and
'queryString' in the same function. In fact, having it in the same code
base seems strange. It makes me wish we had (better!) naming
conventions... Something I've stumbled over often enough during my work
with Postgres - What was it again: 'query_string' (87 times),
'queryString' (77 times) or 'querystr' (42 times)?
However, what about at least adding a comment, so fellow hackers have a
chance of understanding the subtle difference there?
Regards
Markus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-07-21 15:26:55 | pgsql: Add comment about the two different query strings that |
| Previous Message | Tom Lane | 2008-07-21 14:31:04 | Re: Re: [COMMITTERS] pgsql: Adjust things so that the query_string of a cached plan and the |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-07-21 15:02:37 | Re: Default of max_stack_depth and getrlimit |
| Previous Message | chris | 2008-07-21 14:45:09 | Re: Postgres-R: primary key patches |