| From: | "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> |
|---|---|
| To: | "Gregory Stark" <stark(at)enterprisedb(dot)com> |
| Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Pavan Deolasee" <pavan(dot)deolasee(at)gmail(dot)com>, "Pgsql Hackers" <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCHES] VACUUM Improvements - WIP Patch |
| Date: | 2008-07-15 08:23:50 |
| Message-ID: | 487C5E96.1020907@enterprisedb.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Gregory Stark wrote:
> I thought
> we only pruned when we wanted to insert a new tuple and found not enough
> space.
Nope, we prune on any access to the page, if the page is "full enough",
and the pd_prune_xid field suggests that there is something to prune.
The problem with only pruning on inserts is that by the time we get to
heap_insert/heap_update, we're already holding a pin on the page, which
prevents us from acquiring the vacuum lock.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2008-07-15 08:31:29 | Re: [PATCHES] WIP: executor_hook for pg_stat_statements |
| Previous Message | ITAGAKI Takahiro | 2008-07-15 07:25:46 | Re: [PATCHES] WIP: executor_hook for pg_stat_statements |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Simon Riggs | 2008-07-15 08:31:29 | Re: [PATCHES] WIP: executor_hook for pg_stat_statements |
| Previous Message | ITAGAKI Takahiro | 2008-07-15 07:25:46 | Re: [PATCHES] WIP: executor_hook for pg_stat_statements |