Re: Failures in constraints regression test, "read only 0 of 8192 bytes"

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
Cc: Alexander Lakhin <exclusion(at)gmail(dot)com>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com>, Tomas Vondra <tomas(dot)vondra(at)enterprisedb(dot)com>, Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Failures in constraints regression test, "read only 0 of 8192 bytes"
Date: 2024-06-20 23:12:22
Message-ID: 487327.1718925142@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
> In commit af0e7deb4a, I removed the call to RelationCloseSmgr() from
> RelationCacheInvalidate(). I thought it was no longer needed, because we
> no longer free the underlying SmgrRelation.

> However, it meant that if the relfilenode of the relation was changed,
> the relation keeps pointing to the SMgrRelation of the old relfilenode.
> So we still need the RelationCloseSmgr() call, in case the relfilenode
> has changed.

Ouch. How come we did not see this immediately in testing? I'd have
thought surely such a bug would be exposed by any command that
rewrites a heap.

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2024-06-20 23:13:05 Re: Direct SSL connection and ALPN loose ends
Previous Message Michael Paquier 2024-06-20 23:08:19 Re: Pluggable cumulative statistics