From: | "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> |
---|---|
To: | "Simon Riggs" <simon(at)2ndquadrant(dot)com> |
Cc: | "Andrew Dunstan" <andrew(at)dunslane(dot)net>, "Bruce Momjian" <bruce(at)momjian(dot)us>, "Dave Page" <dpage(at)pgadmin(dot)org>, "List pgsql-patches" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: [HACKERS] odd output in restore mode |
Date: | 2008-07-01 10:44:22 |
Message-ID: | 486A0A86.1080509@enterprisedb.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Simon Riggs wrote:
> Patch implements
>
> * recommendation to use GnuWin32 cp on Windows
> * provide "holdtime" delay, default 0 (on all platforms)
> * default stays same on Windows="copy" to ensure people upgrading don't
> get stung
This seems pretty kludgey to me. I wouldn't want to install GnuWin32
utilities on a production system just for the "cp" command, and I don't
know how I would tune holdtime properly for using "copy". And it seems
risky to have defaults that are known to not work reliably.
How about implementing a replacement function for "cp" ourselves? It
seems pretty trivial to do. We could use that on Unixes as well, which
would keep the differences between Win32 and other platforms smaller,
and thus ensure the codepath gets more testing.
(Sorry for jumping into the discussion so late, I didn't follow this
thread earlier, and just read it now in the archives while looking at
the patch.)
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
From | Date | Subject | |
---|---|---|---|
Next Message | Mark Cave-Ayland | 2008-07-01 11:15:17 | Re: WIP patch: reducing overhead for repeat de-TOASTing |
Previous Message | Gregory Stark | 2008-07-01 10:18:47 | Re: Explain XML patch |
From | Date | Subject | |
---|---|---|---|
Next Message | Heikki Linnakangas | 2008-07-01 11:47:26 | Re: Better formatting of functions in pg_dump |
Previous Message | Heikki Linnakangas | 2008-07-01 10:33:24 | Re: extend VacAttrStats to allow stavalues of different types |