Re: BUG #14682: row level security not work with partitioned table

From: Joe Conway <mail(at)joeconway(dot)com>
To: Mike Palmiotto <mike(dot)palmiotto(at)crunchydata(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Noah Misch <noah(at)leadboat(dot)com>, fte(at)nct(dot)ru, PostgreSQL mailing lists <pgsql-bugs(at)postgresql(dot)org>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Amit Langote <amitlangote09(at)gmail(dot)com>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BUG #14682: row level security not work with partitioned table
Date: 2017-06-06 20:07:13
Message-ID: 48656ca0-bdad-cd25-b34a-1995367263f3@joeconway.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-bugs pgsql-hackers

On 06/06/2017 11:57 AM, Mike Palmiotto wrote:
> On Mon, Jun 5, 2017 at 10:36 AM, Robert Haas <robertmhaas(at)gmail(dot)com> wrote:
>> On Mon, Jun 5, 2017 at 10:20 AM, Joe Conway <mail(at)joeconway(dot)com> wrote:
>>> Unless Robert objects, I'll work with Mike to get a fix posted and
>>> committed in the next day or two.
>>
>> That would be great. Thanks.
>
> I have the updated patch with rowsecurity regression tests and rebased
> on master. I've run these and verified locally by feeding
> rowsecurity.sql to psql, but have yet to get the full regression suite
> passing -- it's failing on the constraints regtest and then gets stuck
> in recovery. Undoubtedly something to do with my
> configuration/environment over here. I'm working through those issues
> right now. In the meantime, if you want to see the regression tests as
> they stand, please see the attached patch.

The constraints test passes here, so presumably something you borked
locally. I only see a rowsecurity failure, which is not surprising since
your patch does not include the changes to expected output ;-)
Please resend with src/test/regress/expected/rowsecurity.out included.

Thanks,

Joe

--
Crunchy Data - http://crunchydata.com
PostgreSQL Support for Secure Enterprises
Consulting, Training, & Open Source Development

In response to

Responses

Browse pgsql-bugs by date

  From Date Subject
Next Message isb0459 2017-06-06 20:25:25 BUG #14693: create materialized view forces btrim
Previous Message Mike Palmiotto 2017-06-06 18:57:22 Re: [BUGS] BUG #14682: row level security not work with partitioned table

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2017-06-06 20:25:37 Re: intermittent failures in Cygwin from select_parallel tests
Previous Message Robert Haas 2017-06-06 19:58:04 Re: Why does logical replication launcher set application_name?