Re: Binary difference in pg_internal.init after running pg_initdb multiple times

From: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>
To: "samuel(dot)coulee" <313914592(at)qq(dot)com>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: Binary difference in pg_internal.init after running pg_initdb multiple times
Date: 2018-07-12 13:02:08
Message-ID: 485ee630-70d5-d826-6f75-c8cc688e3411@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 07/12/2018 10:08 AM, samuel.coulee wrote:
> Hi,
>
> In the PG source code function "write_relcache_init_file()", I found that
> the whole 'Relation' structs were directly written into the file
> 'pg_internal.init'. This brings some binary differences of that file, if we
> run pg_initdb multiple times, because the struct 'Relation' contains some
> pointer fields.
>
> And my question is : Could we clear the pointer values in 'Relation' before
> calling write_item(...)?
>
> No benefit regarding function or performance, just for binary
> compatibility...

Binary compatibility with what? Can you describe a scenario where this
actually matters?

regards

--
Tomas Vondra http://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Ashutosh Bapat 2018-07-12 13:03:39 Re: partition pruning doesn't work with IS NULL clause in multikey range partition case
Previous Message Ashutosh Bapat 2018-07-12 13:01:25 Re: partition pruning doesn't work with IS NULL clause in multikey range partition case