| From: | Joe Conway <mail(at)joeconway(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Henry Combrinck <henry(at)zen(dot)co(dot)za>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] BUG #4203: perform dblink() in begin/exception returns wrong SQLSTATE code |
| Date: | 2008-06-01 22:05:04 |
| Message-ID: | 48431D10.2030605@joeconway.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-patches |
Tom Lane wrote:
> Joe Conway <mail(at)joeconway(dot)com> writes:
>> Here is my proposed patch -- as suggested for cvs tip only.
>
> A few comments:
[...great comments as usual...]
Thanks for the excellent feedback! I think the attached addresses it all.
>> I haven't been around enough lately to be sure I understand the process
>> these days. Should I be posting this to the wiki and waiting for the
>> next commit fest, or just apply myself in a day or two assuming no
>> objections?
>
> No, you can apply it yourself when you feel it's ready. The wiki queue
> is just to keep track of stuff that is submitted by non-committers or
> that a committer wants extra review of.
Great. Assuming no other objections I'll commit in a day or three.
Joe
| Attachment | Content-Type | Size |
|---|---|---|
| dblink.2008.06.01.2.diff | text/x-patch | 15.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-06-01 23:19:49 | Re: [BUGS] BUG #4203: perform dblink() in begin/exception returns wrong SQLSTATE code |
| Previous Message | Devrim GÜNDÜZ | 2008-06-01 21:48:18 | Specifying xlog directory during initdb is failing |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-06-01 23:19:49 | Re: [BUGS] BUG #4203: perform dblink() in begin/exception returns wrong SQLSTATE code |
| Previous Message | daveg | 2008-06-01 21:32:23 | Re: Feature: give pg_dump a WHERE clause expression |