| From: | Jorgen Austvik - Sun Norway <Jorgen(dot)Austvik(at)Sun(dot)COM> |
|---|---|
| To: | Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | pg_regress: dbname in PostgreSQL test suite |
| Date: | 2008-05-28 14:12:56 |
| Message-ID: | 483D6868.3080806@sun.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Hi.
pg_regress has a --dbname option (which actually take a list of database
names):
--dbname=DB use database DB (default \"regression\")
... but the PostgreSQL regression test suite does not really support this:
[jaustvik(at)host:regress] ggrep -R "regression" sql/* | grep -v
regression_ | grep -v :--
sql/prepare.sql:EXECUTE q2('regression');
sql/privileges.sql:\c regression
sql/temp.sql:\c regression
I suggest we replace @dbname@ with the first element in the dblist
linked list in convert_sourcefiles_in(). What do you think?
(I can provide a patch if you think it is an acceptable solution.)
-J
--
Jørgen Austvik, Software Engineering - QA
Sun Microsystems Database Group
| Attachment | Content-Type | Size |
|---|---|---|
| jorgen_austvik.vcf | text/x-vcard | 418 bytes |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2008-05-28 14:24:51 | Re: [HACKERS] How embarrassing: optimization of a one-shot query doesn't work |
| Previous Message | Tom Lane | 2008-05-28 14:10:06 | Upcoming back-branch update releases |