Re: Setting a pre-existing index as a primary key

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Bruce Momjian <bruce(at)momjian(dot)us>, "Jonah H(dot) Harris" <jonah(dot)harris(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Setting a pre-existing index as a primary key
Date: 2008-05-10 05:14:35
Message-ID: 48252F3B.6020406@commandprompt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> "Joshua D. Drake" <jd(at)commandprompt(dot)com> writes:
>> Bruce Momjian wrote:
>>> Any comments, ideas, suggestions?
>
>> I would add:
>
>> 5. Modify index name to use appropriate naming style.
>
> Why, and exactly what would you define as "appropriate naming style"?
> The user has always been free to pick whatever constraint name he
> wants.

Well it should be optional but it would be nice if we had the option to
have it renamed per the default... meaning the same output if I were to
do this:

create table foo (id serial primary key);

I end up with "foo_pkey" PRIMARY KEY, btree (id)

Which is nice for consistency.

Sincerely,

Joshua D. Drake

>
> regards, tom lane
>

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Brendan Jurd 2008-05-10 05:57:30 Re: "Claimed" status on Commitfest pages
Previous Message Tom Lane 2008-05-10 04:49:22 "Claimed" status on Commitfest pages