Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Nathan Bossart <nathandbossart(at)gmail(dot)com>
Cc: bt23nguyent <bt23nguyent(at)oss(dot)nttdata(dot)com>, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
Date: 2023-09-26 06:13:45
Message-ID: 482056B1-D930-417C-9473-CB1A045E42AE@yesql.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

> On 26 Sep 2023, at 00:20, Nathan Bossart <nathandbossart(at)gmail(dot)com> wrote:
>
> On Thu, Sep 21, 2023 at 11:18:00AM +0900, bt23nguyent wrote:
>> -basic_archive_configured(ArchiveModuleState *state)
>> +basic_archive_configured(ArchiveModuleState *state, char **logdetail)
>
> Could we do something more like GUC_check_errdetail() instead to maintain
> backward compatibility with v16?

We'd still need something exported to call into which isn't in 16, so it
wouldn't be more than optically backwards compatible since a module written for
17 won't compile for 16, or am I missing something?

--
Daniel Gustafsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Fujii.Yuki@df.MitsubishiElectric.co.jp 2023-09-26 06:26:25 RE: Partial aggregates pushdown
Previous Message Karl O. Pinc 2023-09-26 06:03:28 Re: [PGdocs] fix description for handling pf non-ASCII characters