Re: get rid of psql welcome message

From: "Joshua D(dot) Drake" <jd(at)commandprompt(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org
Subject: Re: get rid of psql welcome message
Date: 2008-04-19 15:50:28
Message-ID: 480A14C4.4030105@commandprompt.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Tom Lane wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>> I think everyone will find a mode they like here.
>
> +1. A marginal style suggestion: if you did
>
> var_welcome_message = GetVariable(pset.vars, "WELCOME_MESSAGE");
> if (!var_welcome_message)
> var_welcome_message = "";
>
> then the subsequent tests would not need null-guards and would become
> much more readable IMHO.

I would like to submit a further patch that has the one line screen
(although I think it will be two), should I wait for this to be applied,
apply it myself and write my patch against the modified tree, or just
write my patch against head and let the committers figure it out?

Joshua D. Drake

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Bruce Momjian 2008-04-19 15:54:34 Re: TODO, FAQs to Wiki?
Previous Message Alvaro Herrera 2008-04-19 15:45:54 Re: TODO, FAQs to Wiki?