| From: | Bryce Nesbitt <bryce2(at)obviously(dot)com> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | pgsql-patches(at)postgresql(dot)org, heikki(at)enterprisedb(dot)com |
| Subject: | Re: Proposed patch - psql wraps at window width |
| Date: | 2008-04-18 07:07:29 |
| Message-ID: | 480848B1.5070402@obviously.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian wrote:
> I don't think you need to do that to get it applied --- there is nothing
> windows-specific in your code.
>
> Is this ready to be applied? Do you want to send a final update or are
> you still testing?
>
Looks good, but I suggest adding "give up if the header is too wide":
if (tcolumns > 0 && tcolumns >= total_header_width)
| Attachment | Content-Type | Size |
|---|---|---|
| print.c | text/plain | 47.4 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Martijn van Oosterhout | 2008-04-18 07:09:27 | Re: Re: [COMMITTERS] pgsql: Repair two places where SIGTERM exit couldleave shared memory |
| Previous Message | Heikki Linnakangas | 2008-04-18 06:52:54 | Re: DROP DATABASE vs patch to not remove files right away |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bryce Nesbitt | 2008-04-18 07:11:58 | Re: Proposed patch - psql wraps at window width |
| Previous Message | Bryce Nesbitt | 2008-04-18 06:44:46 | Coding standards |