From: | Bryce Nesbitt <bryce2(at)obviously(dot)com> |
---|---|
To: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-patches(at)postgresql(dot)org |
Subject: | Re: Proposed patch - psql wraps at window width |
Date: | 2008-04-18 06:36:14 |
Message-ID: | 4808415E.5080905@obviously.com |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Alvaro Herrera wrote:
> * Don't lose warning comments like this one (unless you've removed the
> assumption of course)
>
> /*
> * Assumption: This code used only on strings
> * without multibyte characters, otherwise
> * this_line->width < strlen(this_ptr) and we get
> * an overflow
> */
In fact, that particular assumption was causing a problem, causing a
segfault. I can't be certain, because the multibyte stuff is pretty
intense, but I think I nailed it. Thanks for all your comments!
From | Date | Subject | |
---|---|---|---|
Next Message | Bryce Nesbitt | 2008-04-18 06:44:46 | Coding standards |
Previous Message | Martijn van Oosterhout | 2008-04-18 06:34:49 | Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout |
From | Date | Subject | |
---|---|---|---|
Next Message | Bryce Nesbitt | 2008-04-18 06:44:46 | Coding standards |
Previous Message | Martijn van Oosterhout | 2008-04-18 06:34:49 | Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout |