Re: DROP DATABASE vs patch to not remove files right away

Tom Lane wrote:
> Heikki Linnakangas <heikki(at)enterprisedb(dot)com> writes:
>> Tom Lane wrote:
>>> ISTM that we must fix the bgwriter so that ForgetDatabaseFsyncRequests
>>> causes PendingUnlinkEntrys for the doomed DB to be thrown away too.
>
>> Because of the asynchronous nature of ForgetDatabaseFsyncRequests, this
>> still isn't enough, I'm afraid.
>
> Hm. I notice that there is no bug on Windows because dropdb forces a
> checkpoint before it starts to remove files. Maybe the sanest solution
> is to just do that on all platforms.

Yeah, I don't see any other simple solution.

Patch attached that does the three changes we've talked about:'
- make ForgetDatabaseFsyncRequests forget unlink requests as well
- make rmtree() not fail on ENOENT
- force checkpoint on in dropdb on all platforms

plus some comment changes reflecting what we now know. I will apply this
tomorrow if there's no objections.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com