From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | ITAGAKI Takahiro <itagaki(dot)takahiro(at)oss(dot)ntt(dot)co(dot)jp> |
Cc: | pgsql-patches(at)postgresql(dot)org, Peter Eisentraut <peter_e(at)gmx(dot)net>, Jeremy Drake <pgsql(at)jdrake(dot)com> |
Subject: | Re: Suppress compiler warnings on mingw |
Date: | 2008-04-16 22:40:05 |
Message-ID: | 48068045.5090903@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-patches |
Applied, Thanks.
wiki updated.
cheers
andrew
ITAGAKI Takahiro wrote:
> Peter Eisentraut <peter_e(at)gmx(dot)net> wrote:
>
>
>> Then try using %lu and no casts. That should get rid of the warnings the
>> proper way.
>>
>
> Ok, I rewrote it to use %lu for format strings.
>
>
> Jeremy Drake <pgsql(at)jdrake(dot)com> wrote:
>
>> sizeof(DWORD) is always 4, even on 64-bit windows. sizeof(long) is also
>> always 4.
>>
>
> I got it. This change will work on 64-bit windows, because DWORD is
> defined as 'unsigned long' there, too. We need to support LLP64
> compliers in advance, though.
>
> Regards,
> ---
> ITAGAKI Takahiro
> NTT Open Source Software Center
>
>
>
> ------------------------------------------------------------------------
>
>
>
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2008-04-16 22:50:28 | Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout |
Previous Message | Alex Hunsaker | 2008-04-16 22:38:30 | Re: Patch for Prevent pg_dump/pg_restore from being affected by statement_timeout |