| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Heikki Linnakangas <heikki(at)enterprisedb(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: DROP DATABASE vs patch to not remove files right away |
| Date: | 2008-04-16 21:48:02 |
| Message-ID: | 48067412.7030208@dunslane.net |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Heikki Linnakangas <heikki(at)enterprisedb(dot)com> writes:
>
>> Tom Lane wrote:
>>
>>> ISTM that we must fix the bgwriter so that ForgetDatabaseFsyncRequests
>>> causes PendingUnlinkEntrys for the doomed DB to be thrown away too.
>>>
>
>
>> Because of the asynchronous nature of ForgetDatabaseFsyncRequests, this
>> still isn't enough, I'm afraid.
>>
>
> Hm. I notice that there is no bug on Windows because dropdb forces a
> checkpoint before it starts to remove files. Maybe the sanest solution
> is to just do that on all platforms.
>
>
>
IIRC we did that to avoid an unlink problem :-)
I certainly don't see any particular reason not to do it everywhere.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2008-04-16 21:55:04 | Re: Lessons from commit fest |
| Previous Message | Bruce Momjian | 2008-04-16 21:44:16 | Re: Lessons from commit fest |