From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
---|---|
To: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Clean up some pg_dump tests |
Date: | 2024-02-05 15:42:16 |
Message-ID: | 4801515b-143e-4a4a-be5d-b65a5d461f69@eisentraut.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 02.10.23 09:12, Peter Eisentraut wrote:
> 1) Remove useless entries from "unlike" lists. Runs that are not
> listed in "like" don't need to be excluded in "unlike".
>
> 2) Ensure there is always a "like" list, even if it is empty. This
> makes the test more self-documenting.
> I also added code that checks 1 and 2 automatically and issues a message
> for violations.
I have recently discovered that the same code also exists separately in
the test_pg_dump module test. This should probably be kept consistent.
So here is a patch that adds the same checks there. In this case, we
didn't need to fix any of the existing subtests.
I plan to commit this soon if there are no concerns.
Attachment | Content-Type | Size |
---|---|---|
0001-Apply-pg_dump-test-cleanups-to-test_pg_dump-as-well.patch | text/plain | 1.5 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Jim Jones | 2024-02-05 15:47:55 | Re: Patch: Add parse_type Function |
Previous Message | David E. Wheeler | 2024-02-05 15:14:00 | Re: Patch: Add parse_type Function |