Re: Code-Cleanup: char* -> const char*

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Neil Conway <neilc(at)samurai(dot)com>
Cc: Stefan Huehner <stefan(at)huehner(dot)org>, pgsql-patches(at)postgresql(dot)org
Subject: Re: Code-Cleanup: char* -> const char*
Date: 2007-03-18 16:18:33
Message-ID: 4800.1174234713@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Neil Conway <neilc(at)samurai(dot)com> writes:
> I also don't see the value in modifying the regexp code, as that is just
> an import of Henry Spencer's regexp package.

The same objection applies to most of the proposed changes in /src/port/
since those are generally imports from BSD libc code. I don't mind
cosmetic changes in files that are actually homegrown, but for imported
files it's probably best to avoid unnecessary delta from upstream.

regards, tom lane

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Jaime Casanova 2007-03-18 19:05:07 Re: [COMMITTERS] pgsql: Add GUC temp_tablespaces to provide a default location for
Previous Message Mike Rylander 2007-03-18 16:03:15 Re: [PATCHES] xml2 contrib patch supporting default XML namespaces