| From: | Magnus Hagander <magnus(at)hagander(dot)net> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Alvaro Herrera <alvherre(at)commandprompt(dot)com>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: Re: [COMMITTERS] pgsql: Some cleanups of enum-guc code, per comments from Tom. |
| Date: | 2008-03-17 17:41:41 |
| Message-ID: | 47DEAD55.8090805@hagander.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
Tom Lane wrote:
> Alvaro Herrera <alvherre(at)commandprompt(dot)com> writes:
>> These bits seem to have broken --describe-config:
>> (Perhaps they were already broken in the previous patch, not sure).
>
> It was already broken :-(. Not sure how both Magnus and I missed
> the switch in help_config.c --- I know I grepped for references to
> the PGC_xxx enum constants, and I suppose he did too.
Yeah, that's what I did, and I have no idea how I missed it.
Will fix.
//Magnus
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2008-03-17 17:45:09 | pgsql: Fix postgres --describe-config for guc enums, breakage noted by |
| Previous Message | Tom Lane | 2008-03-17 17:13:54 | pgsql: Revert thinko introduced into prefix_selectivity() by my recent |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gregory Stark | 2008-03-17 17:43:11 | Re: [PATCHES] [0/4] Proposal of SE-PostgreSQL patches |
| Previous Message | Gregory Stark | 2008-03-17 17:38:38 | Re: New style of hash join proposal |