Re: Patch to make some strings available to translations

From: Magnus Hagander <magnus(at)hagander(dot)net>
To: Guillaume Lelarge <guillaume(at)lelarge(dot)info>
Cc: PostgreSQL www <pgsql-www(at)postgresql(dot)org>
Subject: Re: Patch to make some strings available to translations
Date: 2008-03-14 22:57:33
Message-ID: 47DB02DD.6030203@hagander.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-www

Guillaume Lelarge wrote:
> Guillaume Lelarge a écrit :
>> I already sent this patch a few months before, but didn't get an
>> answer on it. So, I updated it and hope for the best :)
>>
>> Anyways, a few words on one file of this patch. I had to change
>> system/global/pgpage.php in two ways.
>>
>> First, to add '.UTF-8' to the locale. Without, I couldn't get any
>> gettext translation to work. I wonder if Adrian had to do the same for
>> his translation. I don't think the way I did it is absolutely right,
>> so I would like comments on this.
>>
>> Second, base_href is set to http://www.postgresql.org/, making any
>> links go to the official website. I'm wondering why we didn't use the
>> value of $_SETTINGS['hosted_url'] for example as it can be a local
>> setting.
>>
>> Any comments ? better ways to solve these ?
>>
>
> I forgot something. "tools/schema.sql" seems to be the schema of the
> pgweb database. Unfortunately, it doesn't seem up to date... at least,
> the organisation column is missing on the events table.

Yeah, that's a known problem. I'm working with JD (I hope) to get it set
up so it'll automatically be committed there from the production db.

//Magnus

In response to

Responses

Browse pgsql-www by date

  From Date Subject
Next Message Guillaume Lelarge 2008-03-14 23:14:06 "New" book on PostgreSQL
Previous Message Guillaume Lelarge 2008-03-14 22:55:15 Re: Patch to make some strings available to translations