| From: | Guillaume Lelarge <guillaume(at)lelarge(dot)info> |
|---|---|
| To: | PostgreSQL www <pgsql-www(at)postgresql(dot)org> |
| Cc: | Magnus Hagander <magnus(at)hagander(dot)net> |
| Subject: | Patch to make some strings available to translations |
| Date: | 2008-03-14 22:10:43 |
| Message-ID: | 47DAF7E3.8070502@lelarge.info |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-www |
Hi,
I already sent this patch a few months before, but didn't get an answer
on it. So, I updated it and hope for the best :)
Anyways, a few words on one file of this patch. I had to change
system/global/pgpage.php in two ways.
First, to add '.UTF-8' to the locale. Without, I couldn't get any
gettext translation to work. I wonder if Adrian had to do the same for
his translation. I don't think the way I did it is absolutely right, so
I would like comments on this.
Second, base_href is set to http://www.postgresql.org/, making any links
go to the official website. I'm wondering why we didn't use the value of
$_SETTINGS['hosted_url'] for example as it can be a local setting.
Any comments ? better ways to solve these ?
Thanks.
Regards.
--
Guillaume.
http://www.postgresqlfr.org
http://dalibo.com
| Attachment | Content-Type | Size |
|---|---|---|
| pgweb.patch | text/x-patch | 25.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Guillaume Lelarge | 2008-03-14 22:23:50 | Re: Patch to make some strings available to translations |
| Previous Message | Joshua D. Drake | 2008-03-14 21:28:19 | Re: mailing lists for US PostgreSQL Association |