Re: Remove FATAL from pg_lzdecompress

From: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: Remove FATAL from pg_lzdecompress
Date: 2008-03-11 17:07:21
Message-ID: 47D6BC49.3020600@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane napsal(a):
> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
>> I attach patch which adds boundaries check and memory overwriting
>> protection when compressed data are corrupted.
>
> Applied with revisions --- it appeared to me that it got the corner case
> wrong where we find a tag just at the end of the input but there's no
> room for the output. We'd fall out of the loop and then the error
> test would think all is well.

Good point. Is there plan to applied also on other branch? I think it is
useful fix for production release as well. Especially when I want to
check all tuples and report tid of corrupted tuples, I'm not able handle
FATAL exception.

Thanks Zdenek

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Tom Lane 2008-03-11 17:15:07 Re: TransactionIdIsInProgress() cache
Previous Message Tom Lane 2008-03-11 16:41:35 Re: [NOVICE] encoding problems