| From: | "Heikki Linnakangas" <heikki(at)enterprisedb(dot)com> |
|---|---|
| To: | "Alvaro Herrera" <alvherre(at)commandprompt(dot)com> |
| Cc: | "Tom Lane" <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "Craig Ringer" <craig(at)postnewspapers(dot)com(dot)au>, "pgsql-patches" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [PERFORM] Very slow (2 tuples/second) sequentialscan after bulk insert; speed returns to ~500 tuples/second aftercommit |
| Date: | 2008-03-11 14:03:08 |
| Message-ID: | 47D6911C.3040605@enterprisedb.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches pgsql-performance |
Alvaro Herrera wrote:
> Heikki Linnakangas wrote:
>
>> I couldn't let this case go, so I wrote a patch. I replaced the linked
>> list with an array that's enlarged at AtSubCommit_childXids when
>> necessary.
>
> Do you still need to palloc the return value from
> xactGetCommittedChildren? Perhaps you can save the palloc/memcpy/pfree
> and just return the pointer to the array already in memory?
Yeah, good point. The callers just need to be modified not to pfree it.
--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2008-03-11 14:15:45 | Re: TransactionIdIsInProgress() cache |
| Previous Message | Larry Rosenman | 2008-03-11 13:59:58 | Re: [PATCHES] Fix for large file support (nonsegment mode support) |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Matthew | 2008-03-11 14:19:09 | Re: count * performance issue |
| Previous Message | Tino Wildenhain | 2008-03-11 14:01:06 | Re: count * performance issue |