Re: pgsql: Fix handling of restricted processes for Windows Vista (mainly),

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Magnus Hagander <magnus(at)hagander(dot)net>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Fix handling of restricted processes for Windows Vista (mainly),
Date: 2008-02-29 21:55:53
Message-ID: 47C87F69.4080500@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


My testing on Vista shows we don't need them for Cygwin.

cheers

andrew

Magnus Hagander wrote:
> AFAIK, we will if we want to run as Administrator on Vista. I'm not
> sure what we're doing there is actually compatible with it though. And
> do we care? I'm perfectly fine saying that we don't support that part
> on cygwin, and just #ifdef the whole thing out there?
>
> //Magnus
>
> Andrew Dunstan wrote:
>>
>> You have broken the Cygwin build (see buildfarm). Will we need those
>> calls to AddUserToDacl() on Cygwin? If not, the simplest thing would
>> be to #ifdef them out, I guess.
>>
>> cheers
>>
>> andrew
>>
>> Magnus Hagander wrote:
>>> Log Message:
>>> -----------
>>> Fix handling of restricted processes for Windows Vista (mainly),
>>> by explicitly adding back the user to the DACL of the new process.
>>> This fixes the failure case when executing as the Administrator
>>> user, which had no permissions left at all after we dropped the
>>> Administrators group.
>>>
>>> Dave Page with some modifications from me
>>>
>>> Modified Files:
>>> --------------
>>> pgsql/src/bin/initdb:
>>> initdb.c (r1.153 -> r1.154)
>>>
>>> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/initdb/initdb.c?r1=1.153&r2=1.154)
>>>
>>> pgsql/src/bin/pg_ctl:
>>> pg_ctl.c (r1.94 -> r1.95)
>>>
>>> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/bin/pg_ctl/pg_ctl.c?r1=1.94&r2=1.95)
>>>
>>> pgsql/src/include:
>>> port.h (r1.117 -> r1.118)
>>>
>>> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/include/port.h?r1=1.117&r2=1.118)
>>>
>>> pgsql/src/port:
>>> exec.c (r1.57 -> r1.58)
>>>
>>> (http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/port/exec.c?r1=1.57&r2=1.58)
>>>
>>>
>>> ---------------------------(end of
>>> broadcast)---------------------------
>>> TIP 3: Have you checked our extensive FAQ?
>>>
>>> http://www.postgresql.org/docs/faq
>>>
>>>
>
>

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2008-02-29 23:31:20 pgsql: Don't call AddUserToDacl on Cygwin
Previous Message Alvaro Herrera 2008-02-29 20:58:33 pgsql: Remove long-unused and broken TCL_ARRAYS.