DTrace probe patch for OS X Leopard

From: Robert Lor <Robert(dot)Lor(at)Sun(dot)COM>
To: pgsql-patches(at)postgresql(dot)org
Subject: DTrace probe patch for OS X Leopard
Date: 2008-02-27 16:05:25
Message-ID: 47C58A45.1090000@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Please find the patch attached per this thread
http://archives.postgresql.org/pgsql-hackers/2008-02/msg00912.php

Notes to committer.

1) Please remove src/include/pg_trace.h as it's no longer needed

2) Need help figuring out how to copy src/backend/util/probes.d from src
tree to
bld tree at build time. It works fine if compilation is done in the src
tree.

3) Note on src/backend/Makefile
The current rule below does not work. After expansion, utils/probes.d
needs
to come right after -s, but currently it shows up at the end after
all the .o files.

utils/probes.o: utils/probes.d $(SUBDIROBJS)
$(DTRACE) $(DTRACEFLAGS) -G -s $(call expand_subsys,$^) -o $@

The following works, but I think the correct way is to include
probes.d as a
dependency and have it show up after -s. I couldn't get it to work
this way with
my somewhat limited knowledge of makefiles.

utils/probes.o: $(SUBDIROBJS)
$(DTRACE) $(DTRACEFLAGS) -G -s $(srcdir)/utils/probes.d -o $@
$(call expand_subsys,$^)

Regards,
-Robert

Attachment Content-Type Size
dtrace-probe.patch text/x-patch 8.1 KB
probes_null.h text/plain 1.3 KB

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Alvaro Herrera 2008-02-27 16:10:31 Re: DTrace probe patch for OS X Leopard
Previous Message Andrew Dunstan 2008-02-27 12:53:05 Re: Fix for initdb failures on Vista