| From: | Ronan Dunklau <ronan(dot)dunklau(at)aiven(dot)io> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, David Zhang <david(dot)zhang(at)highgo(dot)ca>, Zhihong Yu <zyu(at)yugabyte(dot)com> |
| Subject: | Re: ORDER BY pushdowns seem broken in postgres_fdw |
| Date: | 2022-03-31 08:02:54 |
| Message-ID: | 4795577.0VBMTVartN@aivenronan |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Le jeudi 31 mars 2022, 01:41:37 CEST Tom Lane a écrit :
> I looked through this patch. It's going in the right direction,
> but I have a couple of nitpicks:
Thank you Tom for taking a look at this.
> I think that instead of doubling down on a wrong API, we should just
> take that out and move the logic into postgres_fdw.c. This also has
> the advantage of producing a patch that's much safer to backpatch,
> because it doesn't rely on the core backend getting updated before
> postgres_fdw.so is.
It makes total sense.
> If no objections, I think this is committable.
No objections on my end.
--
Ronan Dunklau
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Alvaro Herrera | 2022-03-31 09:14:29 | Re: Database-level collation version tracking |
| Previous Message | Pavel Stehule | 2022-03-31 08:01:02 | Re: proposal: enhancing plpgsql debug API - returns text value of variable content |