| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | James Hilliard <james(dot)hilliard1(at)gmail(dot)com> |
| Cc: | pgsql-hackers(at)lists(dot)postgresql(dot)org, Sergey Shinderuk <s(dot)shinderuk(at)postgrespro(dot)ru>, Thomas Munro <thomas(dot)munro(at)gmail(dot)com> |
| Subject: | Re: [PATCH 1/1] Fix detection of pwritev support for OSX. |
| Date: | 2021-01-19 15:27:21 |
| Message-ID: | 479372.1611070041@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
James Hilliard <james(dot)hilliard1(at)gmail(dot)com> writes:
> Fixes:
> gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -Wno-unused-command-line-argument -O2 -I../../../../src/include -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX11.1.sdk -c -o fd.o fd.c
> fd.c:3661:10: warning: 'pwritev' is only available on macOS 11.0 or newer [-Wunguarded-availability-new]
We already dealt with that by not selecting an SDK newer than the
underlying OS (see 4823621db). I do not believe that your proposal
is more reliable than that approach, and it's surely uglier. Are
we really going to abandon Autoconf's built-in checking method every
time Apple adds an API they should have had ten years ago? If so,
you forgot preadv ...
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | James Hilliard | 2021-01-19 15:36:49 | Re: [PATCH 1/1] Fix detection of pwritev support for OSX. |
| Previous Message | Tom Lane | 2021-01-19 15:19:57 | Re: search_plan_tree(): handling of non-leaf CustomScanState nodes causes segfault |