| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | "Magnus Hagander" <mha(at)sollentuna(dot)net> |
| Cc: | "Joe Brown" <joebrown(at)rclooke(dot)com>, "PostgreSQL-patches" <pgsql-patches(at)postgresql(dot)org> |
| Subject: | Re: [BUGS] BUG #1466: #maintenace_work_mem = 16384 |
| Date: | 2005-02-13 18:04:15 |
| Message-ID: | 477.1108317855@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-patches |
"Magnus Hagander" <mha(at)sollentuna(dot)net> writes:
> What do you think of the following as a fix?
I dislike going through write_stderr because it requires an extra,
useless gettext() call, and because in the Windows case it imposes
an arbitrary length limit that is certain to be exceeded. The length
limit is probably OK for the existing limited usages of write_stderr,
but you can't assume that every log message the system ever prints
is going to be under 2K.
The proposed test on Redirect_stderr looks pretty fishy too; for one
thing it will almost certainly not be the right thing inside the stderr
logger subprocess itself.
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Magnus Hagander | 2005-02-13 18:27:32 | Re: [BUGS] BUG #1466: #maintenace_work_mem = 16384 |
| Previous Message | Magnus Hagander | 2005-02-13 17:38:27 | Re: [BUGS] BUG #1466: #maintenace_work_mem = 16384 |