Re: Proposed patch for contrib/cube

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Joshua Reich <josh(at)root(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: Proposed patch for contrib/cube
Date: 2006-07-17 18:21:43
Message-ID: 4766.1153160503@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Joshua Reich <josh(at)root(dot)net> writes:
> ... build a cube by specifying 2 arrays, one for the UR
> coordinate, one for LL.
> I hope people find this useful, and if so, we can add it to contrib/cube.

Seems useful, but it needs work: it will fail on toasted arrays or
arrays containing nulls. I'd suggest converting it to V1 call protocol
too, as the V1 GETARG macros are the easiest answer to the toasting
problem. Null array elements are a new issue in CVS HEAD, you'd need
to test against HEAD for that.

As a matter of style, would it be better to error out if the arrays
are not the same length?

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Zdenek Kotala 2006-07-17 19:28:21 TODO: Mark change-on-restart-only values in postgresql.conf
Previous Message Neil Conway 2006-07-17 17:45:23 Re: plPHP and plRuby