From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Magnus Hagander <magnus(at)hagander(dot)net> |
Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>, "Patches (PostgreSQL)" <pgsql-patches(at)postgresql(dot)org> |
Subject: | Re: buildenv.pl/buildenv.bat |
Date: | 2007-12-09 19:40:37 |
Message-ID: | 475C44B5.6090203@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers pgsql-patches |
Magnus Hagander wrote:
>>
>> You seem to have misunderstood what I am suggesting. Of course we should
>> document use of buildenv.pl in addition to the hacky fix to the .bat
>> files. The hack is the part that would be invisible. The docs would be
>> visible and contain what would be our ongoing practice.
>>
>
> Correct, I was misunderstanding it :-)
>
> I still can't say I like that hack though. I'd rather document that you
> have to do it in the .bat file for docs + gui build.
>
> But it's better than what I thought you were proposing :-)
>
>
>
Well, I honestly think we can live with it for one cycle. As soon as 8.4
opens I'll get to work converting these .bat files to pure one line
wrappers.
Meanwhile, here's the proposed patch. If you want something else you'll
have to do it.
I don't know how many people regularly build on Windows other than you,
me and Dave.
cheers
andrew
Attachment | Content-Type | Size |
---|---|---|
buildenv.patch | text/x-patch | 7.8 KB |
From | Date | Subject | |
---|---|---|---|
Next Message | Bruce Momjian | 2007-12-09 19:51:59 | Re: Release Note Changes |
Previous Message | Tom Lane | 2007-12-09 19:34:08 | Re: whats the deal with -u ? |
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Chernow | 2007-12-09 20:08:09 | Re: PGparam timestamp question |
Previous Message | Tom Lane | 2007-12-09 18:26:50 | Re: PGparam timestamp question |