Re: pg_regress: paths in largeobject test

From: Jorgen Austvik - Sun Norway <Jorgen(dot)Austvik(at)Sun(dot)COM>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: pg_regress: paths in largeobject test
Date: 2007-11-30 08:43:30
Message-ID: 474FCD32.4070502@sun.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Tom Lane wrote:
> Jorgen Austvik - Sun Norway <Jorgen(dot)Austvik(at)Sun(dot)COM> writes:
>> I believe the results paths in line 139 and 144 are missing the
>> @abs_builddir@ qualifier.
>
> I'd put it the other way around: likely we should get rid of the
> one use of @abs_builddir(at)(dot)

He, he.

Generally I prefer explicit over implicit (having the full paths make
troubleshooting easier), but in this case you have the additional aspect
of the lo_import operating relative to the client, while lo_export
operates relative to the server. If you remove @abs_builddir@ on the
first one, you might e.g. get problems like this:

SELECT lo_export(loid, 'results/lotest.txt') FROM lotest_stash_values;
ERROR: could not create server file "results/lotest.txt": No such
file or directory

-J
--

Jørgen Austvik, Software Engineering - QA
Sun Microsystems Database Technology Group

Attachment Content-Type Size
jorgen.austvik.vcf text/x-vcard 391 bytes

In response to

Responses

Browse pgsql-patches by date

  From Date Subject
Next Message Brendan Jurd 2007-11-30 09:14:14 Re: [GENERAL] Empty arrays with ARRAY[]
Previous Message NikhilS 2007-11-30 07:04:05 Re: [DOCS] Partition: use triggers instead of rules