| From: | Peter Eisentraut <peter(at)eisentraut(dot)org> |
|---|---|
| To: | "Anton A(dot) Melnikov" <a(dot)melnikov(at)postgrespro(dot)ru>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Use XLOG_CONTROL_FILE macro everywhere? |
| Date: | 2024-04-24 09:02:14 |
| Message-ID: | 474746ef-fa9f-400e-902e-3bb018320ca0@eisentraut.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 19.04.24 05:50, Anton A. Melnikov wrote:
> There is a macro XLOG_CONTROL_FILE for control file name
> defined in access/xlog_internal.h
> And there are some places in code where this macro is used
> like here
> https://github.com/postgres/postgres/blob/84db9a0eb10dd1dbee6db509c0e427fa237177dc/src/bin/pg_resetwal/pg_resetwal.c#L588
> or here
> https://github.com/postgres/postgres/blob/84db9a0eb10dd1dbee6db509c0e427fa237177dc/src/common/controldata_utils.c#L214
>
> But there are some other places where the control file
> name is used as text string directly.
>
> May be better use this macro everywhere in C code?
I don't know. I don't find XLOG_CONTROL_FILE to be a very intuitive
proxy for "pg_control".
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Anton A. Melnikov | 2024-04-24 09:13:10 | Re: Use XLOG_CONTROL_FILE macro everywhere? |
| Previous Message | Michael Paquier | 2024-04-24 08:56:54 | Re: WIP Incremental JSON Parser |