| From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
|---|---|
| To: | Martijn van Oosterhout <kleptog(at)svana(dot)org> |
| Cc: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers(at)postgresql(dot)org |
| Subject: | Re: psql -f doesn't complain about directories |
| Date: | 2007-11-15 10:25:02 |
| Message-ID: | 473C1E7E.5030001@sun.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Martijn van Oosterhout napsal(a):
> On Wed, Nov 14, 2007 at 09:33:17PM +0100, Zdenek Kotala wrote:
>>> Sure, why not. To be honest I think that psql shouldn't be ignoring the
>>> EISDIR error the kernel is returning.
>> But it works when you open directory in read-only mode. See posix
>> definition:
>>
>> [EISDIR]
>> The named file is a directory and oflag includes O_WRONLY or O_RDWR.
>
> $ strace psql -f /tmp
> <snip>
> open("/tmp", O_RDONLY|O_LARGEFILE) = 4
> <snip>
> read(4, 0xb7f1b000, 4096) = -1 EISDIR (Is a directory)
>
> Which is subsequently ignored. I'm hoping it doesn't ignore other
> errors, like EIO or EPIPE,
Yes, you have right I checked only open command which works fine, but read fails.
Zdenek
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Gregory Stark | 2007-11-15 10:41:16 | Re: Simplifying Text Search |
| Previous Message | Gregory Stark | 2007-11-15 10:08:13 | Re: LDC - Load Distributed Checkpoints with PG8.3b2 on Solaris |