| From: | Fujii Masao <masao(dot)fujii(at)oss(dot)nttdata(dot)com> |
|---|---|
| To: | "kuroda(dot)hayato(at)fujitsu(dot)com" <kuroda(dot)hayato(at)fujitsu(dot)com>, 'Kyotaro Horiguchi' <horikyota(dot)ntt(at)gmail(dot)com> |
| Cc: | "houzj(dot)fnst(at)fujitsu(dot)com" <houzj(dot)fnst(at)fujitsu(dot)com>, "ikedamsh(at)oss(dot)nttdata(dot)com" <ikedamsh(at)oss(dot)nttdata(dot)com>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>, "tgl(at)sss(dot)pgh(dot)pa(dot)us" <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Subject: | Re: Allow escape in application_name |
| Date: | 2021-10-12 04:25:01 |
| Message-ID: | 4737ce62-6d46-49e9-e687-3468c6e13ea4@oss.nttdata.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2021/10/07 11:46, kuroda(dot)hayato(at)fujitsu(dot)com wrote:
> So now we can choose from followings:
>
> * ignore such differences and use isdigit() and strtol()
> * give up using them and implement two static support functions
>
> How do you think? Someone knows any other knowledge about locale?
Replacing process_log_prefix_padding() with isdigit()+strtol() is
just refactoring and doesn't provide any new feature. So they
basically should work in the same way. If the behavior of isdigit()+strtol()
can be different from process_log_prefix_padding(), I'd prefer to
the latter option you suggested, i.e., give up using isdigit()+strtol().
OTOH, of course if the behaviors of them are the same,
I'm ok to use isdigit()+strtol(), though.
Regards,
--
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Etsuro Fujita | 2021-10-12 04:33:39 | Re: postgres_fdw: misplaced? comments in connection.c |
| Previous Message | Tom Lane | 2021-10-12 03:21:34 | Re: Corruption with IMMUTABLE functions in index expression. |