Re: nextval parameter is not clear

From: Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
To: "David G(dot) Johnston" <david(dot)g(dot)johnston(at)gmail(dot)com>, Kirk Wolak <wolakk(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Bruce Momjian <bruce(at)momjian(dot)us>, ailjushkin(at)gmail(dot)com, pgsql-docs(at)lists(dot)postgresql(dot)org
Subject: Re: nextval parameter is not clear
Date: 2022-12-08 14:15:19
Message-ID: 47353838812604058c965ee721bade7260787d83.camel@cybertec.at
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-docs

On Wed, 2022-12-07 at 14:32 -0700, David G. Johnston wrote:
> While I agree with the conclusion that the function signature is an example,
> and having more than one for these is probably overkill, we can address the
> OP's complaint quite easily by doing what we do in many other places, give
> each parameter in the function signature a name.  I've modified v9 to include
> those and attach it here as v10.  I do think this suffices as a response
> to this complaint.
>
> Bikeshedding on the names for setval, and maybe an attempt to incorporate
> the parameter name into the prose, can be considered, though.

Thanks for looking into that, and parameter names are fully sufficient to
clarify the usage.

Your patch is good, except that you forgot to add the link target on the CREATE
SEQUENCE page.

> My thoughts regarding incorporating pg_get_serial_sequence and usage of these
> functions in a more common, GENERATED AS IDENTITY environment, can be considered
> in a separate thread should I or anyone else wish to do so.

+1

Yours,
Laurenz Albe

In response to

Browse pgsql-docs by date

  From Date Subject
Next Message David G. Johnston 2022-12-09 15:28:43 Re: Clarify note about DISTINCT and ORDER BY in aggregates
Previous Message Vik Fearing 2022-12-08 12:31:24 Clarify note about DISTINCT and ORDER BY in aggregates