Re: mingw regression test fixes

From: "Andrew Dunstan" <andrew(at)dunslane(dot)net>
To: <claudio(dot)natoli(at)memetrics(dot)com>
Cc: <pgsql-patches(at)postgresql(dot)org>
Subject: Re: mingw regression test fixes
Date: 2004-05-01 03:22:52
Message-ID: 4732.24.211.141.25.1083381772.squirrel@www.dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-patches

Claudio Natoli said:
>> Strictly speaking, the pwd flags test should probably depend
>> in the test
>> platform rather than the target platform. Something like:
>>
>> case `uname` in
>> MINGW32*)
>> PWDFLAGS=-W;;
>> *)
>> PWDFLAGS=;;
>> esac
>
> There's three other tests that use $host_platform in pg_regress.sh in
> the exact same manner. Not sure I understand the objection.
>

if you tested a mingw build from some other platform pwd might not
understand the -W flag. It's probably a minor nit at best.

cheers

andrew

In response to

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-05-01 03:25:02 Timezone library on Unix
Previous Message Andrew Dunstan 2004-05-01 03:18:02 Re: win32 build and test issues