| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Christoph Berg <christoph(dot)berg(at)credativ(dot)de>, Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] Pass COPT and PROFILE to CXXFLAGS as well |
| Date: | 2019-01-04 10:41:15 |
| Message-ID: | 472cd811-b913-cc3b-686d-59eecff6807d@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 21/11/2018 14:28, Christoph Berg wrote:
> The context here is that we want to use the *FLAGS from pg_config for
> compiling PG extension packages, but add additional *FLAGS from the
> extension build environment. Merging the pg_config CFLAGS with the
> environment CFLAGS seemed hard/weird/error-prone, so what we are doing
> now is https://salsa.debian.org/postgresql/postgresql-common/blob/master/pg_buildext#L53-55
>
> if [ "${CFLAGS:-}" ]; then
> export COPT="$CFLAGS"
> fi
Note that pgxs supports PG_CPPFLAGS for adding custom pieces to CPPFLAGS
in a safe way. Maybe we should add an equivalent for CFLAGS? It's just
that it hasn't been needed so far.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Kristjan Tammekivi | 2019-01-04 10:45:42 | Potentially undocumented behaviour change in Postgres 11 concerning OLD record in an after insert trigger |
| Previous Message | Peter Eisentraut | 2019-01-04 10:32:31 | Re: BUG #15548: Unaccent does not remove combining diacritical characters |