Re: perltidy tweaks

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Cc: pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: perltidy tweaks
Date: 2018-04-26 16:33:58
Message-ID: 4723.1524760438@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> writes:
> I prpose two tweaks for the perltidy configuration:
> - The new perltidy version can avoid writing backup files, so we don't
> need to explicitly delete them after.

+1

> - Use option --nooutdent-long-quotes. This is similar to a change we
> made for pgindent in the C code a while ago. See patch for the results.

No strong opinion as to whether to do that or not, but if we do, I wonder
if we shouldn't also select --nooutdent-long-comments. I noticed a few
places where it was doing that (ie moving comments left if they went past
the right margin) and didn't particularly like it.

What would be more per project style is to reflow overly-wide comments
into multiple lines, but I don't see an option for that :-(

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2018-04-26 17:39:47 Re: [HACKERS] Clock with Adaptive Replacement
Previous Message Alvaro Herrera 2018-04-26 16:06:12 Scariest patch tournament, PostgreSQL 11 edition