| From: | Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Datum should be defined outside postgres.h |
| Date: | 2007-10-25 15:38:46 |
| Message-ID: | 4720B886.8080102@sun.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
Tom Lane wrote:
> Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM> writes:
>> Tom Lane wrote:
>>> Why in the world is ecpg including either primnodes.h or postgres.h?
>
>> The problem is that ecpg shares parser.c source code and this code
>> includes postgres.h.
>
> ecpg cannot do that. It would fail if parser.c happened to use anything
> that won't compile in frontend, eg elog() or palloc(). It's mere luck
> that it's worked for him so far.
>
> Considering that ecpg has its own copy of all of gram.y and scan.l,
> sharing parser.c isn't much of a savings anyway.
OK. I will create separate infrastructure fix for ecpg.
Zdenek
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2007-10-25 15:46:07 | Re: Datum should be defined outside postgres.h |
| Previous Message | Zdenek Kotala | 2007-10-25 15:35:23 | Re: Datum should be defined outside postgres.h |