Re: MaxOffsetNumber versus MaxHeapTuplesPerPage

From: Heikki Linnakangas <heikki(at)enterprisedb(dot)com>
To: Zdenek Kotala <Zdenek(dot)Kotala(at)Sun(dot)COM>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: MaxOffsetNumber versus MaxHeapTuplesPerPage
Date: 2007-10-25 10:16:50
Message-ID: 47206D12.6080600@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Zdenek Kotala wrote:
> Is there any reason to have both these macros? By my opinion
> MaxHeapTuplesPerPage is more accurate and it should replace all
> MaxOffsetNumber occurrence.

We use MaxOffsetNumber with index pages as well.

At quick glance, the only places I can see where we could replace
MaxOffsetNumber with MaxHeapTuplesPerPage, are in vacuum.c and
vacuumlazy.c, where we allocate arrays big enough to hold potentially a
full page's worth of tuples. We could change those, but it's hardly
worth the trouble.

--
Heikki Linnakangas
EnterpriseDB http://www.enterprisedb.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Simon Riggs 2007-10-25 11:05:07 Re: order by in cursor declaration does not allow update
Previous Message Gregory Stark 2007-10-25 10:03:40 Re: PostGreSQL and zlib